Remove policycontroller block from ACM configmanagement in gkehub_feature_membership tests #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture_membership tests (#12166) [upstream:4c1d5e80e92281ce9e30f483b5dcdef5493d3a0f] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
shuyama1
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit 73676db
into
GoogleCloudPlatform:main
4 of 6 checks passed
modular-magician
deleted the
downstream-pr-4c1d5e80e92281ce9e30f483b5dcdef5493d3a0f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the permadiff in
policy_controllerfield insideconfigmanagement(hashicorp/terraform-provider-google#14591 (comment))Copying data of
policycontrollerinto ACM is async and the non-atomic operation caused the permadiff inpolicy_controllerfield insideconfigmanagement.As
policycontrolleris deprecated inside ACM, it is going to be removed fromconfigmanagementin the ACM tests.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#12166